Skip to content

Fix typos and prevent shooting error#74

Open
MHoseinJ wants to merge 3 commits intoMatinAfzal:developfrom
MHoseinJ:dev
Open

Fix typos and prevent shooting error#74
MHoseinJ wants to merge 3 commits intoMatinAfzal:developfrom
MHoseinJ:dev

Conversation

@MHoseinJ
Copy link
Copy Markdown

i fixed following things

  • changed bltime to blitme in class Ship
  • avoiding error if a bullet shooted while there is no screen

no new features added or removed

Added a condition to `fire_bullet` function to avoid error when there is no display.
@MHoseinJ MHoseinJ changed the base branch from main to develop December 30, 2025 12:34
@MatinAfzal
Copy link
Copy Markdown
Owner

i fixed following things

  • changed bltime to blitme in class Ship
  • avoiding error if a bullet shooted while there is no screen

no new features added or removed

Hi Mohammad Hossein,
Thanks for the changes you made.
As you can see, there’s a very small conflict in src/game_functions.py that needs to be resolved before merging.
I usually resolve these conflicts myself, but right now Im really busy and can’t.
It would be great if you could fix it and test it so I can merge it.
Good luck.

@MatinAfzal MatinAfzal added the invalid This doesn't seem right label Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right trivial change Under review Wait a few hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants