Update Laravel (WIP), NPM packages & add Vagrant#14
Open
MaxKorlaar wants to merge 2 commits intomasterfrom
Open
Update Laravel (WIP), NPM packages & add Vagrant#14MaxKorlaar wants to merge 2 commits intomasterfrom
MaxKorlaar wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new Vagrantfile to set up a Vagrant development environment and configure Laravel Homestead, along with updating NPM packages and beginning a Laravel upgrade (WIP).
- Introduces a Vagrantfile with provisions for alias files, after and customization scripts.
- Configures host updater/host manager plugins based on available settings.
Comments suppressed due to low confidence (1)
Vagrantfile:8
- [nitpick] The variable 'confDir' does not follow Ruby naming conventions. Consider renaming it to 'conf_dir' to improve readability and consistency.
confDir = $confDir ||= File.expand_path("vendor/laravel/homestead", File.dirname(__FILE__))
| end | ||
|
|
||
| if File.exist? homesteadYamlPath then | ||
| settings = YAML::load(File.read(homesteadYamlPath)) |
There was a problem hiding this comment.
Using YAML::load may lead to unsafe deserialization. Consider using YAML.safe_load to mitigate potential security risks.
Suggested change
| settings = YAML::load(File.read(homesteadYamlPath)) | |
| settings = YAML.safe_load(File.read(homesteadYamlPath)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel upgrade is still a work in progress. Unfortunately, during my internship I don't know when I will be able to finish this.