Open
Conversation
Member
|
Thanks for the PR. |
1. Media time is signed value 2. Media time is in unit of mdhd time scale. Since mdhd comes after edts, we don't know mdhd_TimeScale yet when handle edts. Give a hint to user on which time scale to use. Fix MediaArea#1441
quink-black
force-pushed
the
bugfix-mp4-editlist
branch
from
b998ecf to
56bc23f
Compare
JeromeMartinez
requested changes
Oct 26, 2021
Member
JeromeMartinez
left a comment
JeromeMartinez
left a comment
There was a problem hiding this comment.
There is an impact on the value -1, which was previously forced to unsigned.
Search for .edts[0].Delay==(int32u)-1 and replace by .edts[0].Delay==-1. 3x in the code.
(generally speaking this part of the code is one of the most awful, and definitely need a complete refactoring as well as adding more boxes in the parsing... But classic excuse: lack of time :( ).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edts, we don't know mdhd_TimeScale yet when handle edts. Give a hint
to user on which time scale to use.
Fix #1441