Improve CLI: support --palace argument after subcommands for consistent usage#861
Open
iron-prog wants to merge 3 commits intoMemPalace:developfrom
Open
Improve CLI: support --palace argument after subcommands for consistent usage#861iron-prog wants to merge 3 commits intoMemPalace:developfrom
iron-prog wants to merge 3 commits intoMemPalace:developfrom
Conversation
Author
|
Any update on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
--palaceargument only works when provided before the subcommand:mempalace –palace ./p1 mine project
However, passing it after the subcommand (which is more intuitive) results in an error:
Solution
Added
--palaceargument support to relevant subcommands:initminesearchcompresswake-upstatusmigrateIntroduced a helper
resolve_palace()to centralize palace path resolutionUpdated command handlers to use the helper for consistency
Used environment override (
MEMPALACE_PALACE) ininitto respect custom palace pathWhy this matters
This aligns MemPalace CLI behavior with common CLI tools (e.g., git, docker, kubectl), making it more intuitive and user-friendly.
Checklist
python -m pytest tests/ -v)ruff check .)