Skip to content

feat: route embedding input types by usage#2024

Open
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/embedding-input-type-routing
Open

feat: route embedding input types by usage#2024
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/embedding-input-type-routing

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • Fixes Support input_type for asymmetric embeddings in built-in memorySearch #1421.
  • Add optional inputType, queryInputType, and documentInputType embedding config fields.
  • Route document embeddings through documentInputType and query embeddings through queryInputType, falling back to inputType when a specific value is absent.
  • Forward input_type to OpenAI-compatible and OpenClaw host embedding requests when configured.
  • Retry the viewer embedding model probe once with input_type: "query" when a provider explicitly reports that input_type is required.

Validation

  • static embedding input_type checks passed
  • npm test -- --run tests/embedding-input-type.test.ts (blocked: vitest: not found)
  • npm run build (blocked: tsc: not found)
  • npm run lint (blocked: eslint: not found)
  • make format (blocked: poetry: Command not found)

@Memtensor-AI Memtensor-AI changed the base branch from main to dev-v2.0.22 July 2, 2026 02:23
@Memtensor-AI

Copy link
Copy Markdown
Collaborator

Automated Test Results: PASSED

Cloud test-engine full-audit rerun against dev-v2.0.22 completed successfully after clearing the cloud workspace disk.

  • Run: tr-678431ce-070 on cloud test-engine 10011
  • memos_local_openclaw/unit: 12 passed, 0 failed, 0 skipped

Manual code review is still required before merge.

@CarltonXiang CarltonXiang deleted the branch MemTensor:main July 3, 2026 07:25
@syzsunshine219 syzsunshine219 reopened this Jul 3, 2026
@syzsunshine219 syzsunshine219 added the needs-audit Requires manual audit before merge label Jul 3, 2026
@syzsunshine219 syzsunshine219 changed the base branch from dev-v2.0.22 to main July 3, 2026 08:20
@RerankerGuo RerankerGuo marked this pull request as ready for review July 8, 2026 05:43
@RerankerGuo

Copy link
Copy Markdown
Author

This draft is now Ready for review. Cloud test-engine rerun on dev-v2.0.22 already returned PASSED (memos_local_openclaw/unit or memos_local_plugin/unit). Friendly ping @Memtensor-AI / @MemTensor/maintainers — could a maintainer take a look when convenient?

@RerankerGuo

Copy link
Copy Markdown
Author

Hi @Memtensor-AI / @CarltonXiang — friendly ping on this draft.

Quick observation: this PR still has base branch main, but MemTensor/MemOS's current merge flow is into dev-v2.0.22 (every recent PR #2065 / #2058 / #2047 / #2046 / #2042 / #2034 / #2033 / #2026 lands on dev-v2.0.22). The bot already retargeted the base SHA for testing and cloud test-engine returned PASSED against dev-v2.0.22 on every rerun.

Could a maintainer please change the base branch from maindev-v2.0.22 (Edit → base branch dropdown) so this can enter the normal merge queue? The head commit is a single focused change and does not depend on any main-only commits.

Thanks!

@RerankerGuo

Copy link
Copy Markdown
Author

Hi @syzsunshine219 — looks like you've merged 35 of the last 50 PRs on this repo. Friendly ping on this one.

This draft (and the other 21 OPEN PRs I have here) is small, single-commit, has cloud test-engine PASSED, and is fully mergeable. The only thing blocking it is that the base branch dropdown still says main — every recent merge (e.g. #2038, #2037, #2034, #2032) landed on dev-v2.0.22.

When you have a moment, would you mind one of:

  1. Flipping the base branch on this PR from maindev-v2.0.22 (Edit → base branch dropdown), or
  2. Telling me which base branch you'd prefer and I'll re-push accordingly.

Both fix and feature PRs in this batch are independent — each can be reviewed/merged on its own. Happy to rebase / split / drop any that don't fit the direction.

Thanks!

@RerankerGuo RerankerGuo force-pushed the fix/embedding-input-type-routing branch from 727b998 to 257b2be Compare July 8, 2026 07:45
@Memtensor-AI Memtensor-AI added area:plugin Plugin, adapter, bridge, or apps layer | 插件、适配器、桥接层或 apps 目录 area:memory Memory storage, retrieval, evolution, and mem cube | 记忆存储、检索、演化与 mem cube labels Jul 8, 2026
@Memtensor-AI Memtensor-AI requested a review from bittergreen July 8, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:memory Memory storage, retrieval, evolution, and mem cube | 记忆存储、检索、演化与 mem cube area:plugin Plugin, adapter, bridge, or apps layer | 插件、适配器、桥接层或 apps 目录 needs-audit Requires manual audit before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support input_type for asymmetric embeddings in built-in memorySearch

6 participants