Skip to content

Guard Merge against mock transcripts#3194

Open
isaiahb wants to merge 1 commit into
devfrom
codex/merge-mock-guard
Open

Guard Merge against mock transcripts#3194
isaiahb wants to merge 1 commit into
devfrom
codex/merge-mock-guard

Conversation

@isaiahb

@isaiahb isaiahb commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Skip Local Merge AI analysis for deterministic cloud-v2 mock transcript text while still recording the transcript/activity.
  • Remove a stale Bluetooth SDK public export for setCaptureLedEnabled, which was intentionally removed from the native SDK path.

Validation

  • bun run --cwd miniapps/merge build
  • bun run --cwd mobile/modules/bluetooth-sdk prepare
  • bun install --frozen-lockfile
  • git diff --check

Notes

PR #3178 was squash-merged while this fix was being made, so this is the small follow-up against current dev.


Note

Low Risk
Behavioral guard in Merge miniapp and removal of an unused SDK binding with no auth, security, or data-path changes.

Overview
Merge now detects cloud-v2 mock transcripts (via source/provider === "mock" or deterministic mock … <n> text), still upserts and broadcasts them, records a silent decision, and returns before final/interim insight analysis so the backend is not called for test traffic.

The mobile Bluetooth SDK public surface drops setCaptureLedEnabled, which no longer exists on the native module after an intentional removal.

Reviewed by Cursor Bugbot for commit 76d900c. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Skip Merge analysis for deterministic mock transcripts while still recording the transcript and activity. Remove the stale setCaptureLedEnabled export from the mobile/modules/bluetooth-sdk public API.

Written for commit 76d900c. Summary will update on new commits.

Review in cubic

@isaiahb isaiahb requested a review from a team as a code owner June 18, 2026 19:34
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

📋 PR Review Helper

📱 Mobile App Build

Ready to test! (commit 76d900c)

📥 Download APK

🕶️ ASG Client Build

Waiting for build...


🔀 Test Locally

gh pr checkout 3194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant