Guard Merge against mock transcripts#3194
Open
isaiahb wants to merge 1 commit into
Open
Conversation
Contributor
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build⏳ Waiting for build... 🔀 Test Locallygh pr checkout 3194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setCaptureLedEnabled, which was intentionally removed from the native SDK path.Validation
bun run --cwd miniapps/merge buildbun run --cwd mobile/modules/bluetooth-sdk preparebun install --frozen-lockfilegit diff --checkNotes
PR #3178 was squash-merged while this fix was being made, so this is the small follow-up against current
dev.Note
Low Risk
Behavioral guard in Merge miniapp and removal of an unused SDK binding with no auth, security, or data-path changes.
Overview
Merge now detects cloud-v2 mock transcripts (via
source/provider === "mock"or deterministicmock … <n>text), still upserts and broadcasts them, records a silent decision, and returns before final/interim insight analysis so the backend is not called for test traffic.The mobile Bluetooth SDK public surface drops
setCaptureLedEnabled, which no longer exists on the native module after an intentional removal.Reviewed by Cursor Bugbot for commit 76d900c. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Skip Merge analysis for deterministic mock transcripts while still recording the transcript and activity. Remove the stale
setCaptureLedEnabledexport from themobile/modules/bluetooth-sdkpublic API.Written for commit 76d900c. Summary will update on new commits.