Document Mapbox token setup for mobile builds#3407
Open
aisraelov wants to merge 1 commit into
Open
Conversation
Contributor
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build⏳ Waiting for build... 🔀 Test Locallygh pr checkout 3407 |
Contributor
PR Agent Orchestrator State{
"cycle": 2,
"fixRound": 0,
"totalReviewerRuns": 2,
"consecutiveNoNewReviews": 2,
"openFindings": [],
"resolvedFindings": [],
"nitFindings": [],
"phase": "discovery",
"status": "in_progress",
"lastPair": [],
"stagnationFixRounds": 0,
"lastOpenCount": 0,
"fingerprintReopenCounts": {},
"mutedFingerprints": []
} |
Contributor
🤖 PR Agent Review — cycle 2✅ No blocking findings · 0 blocking · 0 nits No model reviews ran this cycle. Updated automatically by the PR Agent Orchestrator each review cycle. Nits do not block merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the two-token distinction (runtime
pk.vs build-timesk.downloads token), where the downloads token must live (~/.netrcfor iOS/SPM,MAPBOX_DOWNLOADS_TOKENfor Gradle and CI), the Navigation-SDK "active subscription required" gotcha, and account-custody guidance — written up after this week's orphaned-account fire drill where the only working downloads token belonged to a departed employee's personal Mapbox account.Note
Low Risk
Documentation-only change to AGENTS.md with no runtime or build script modifications.
Overview
Adds a Mapbox tokens section to
mobile/AGENTS.mdso mobile contributors can distinguish the runtime public token (pk.…inEXPO_PUBLIC_MAPBOX_ACCESS_TOKEN) from the build-time downloads token (sk.…,Downloads:Read).The new docs spell out where the secret must be configured:
~/.netrcfor iOS/SPM,MAPBOX_DOWNLOADS_TOKENfor Android Gradle, and the same name as a GitHub Actions secret for CI. It also records operational gotchas—Navigation SDKdash-native401s tied to an active billing/subscription, one-time display of secret values, and keeping tokens on a shared org Mapbox account rather than personal accounts.Reviewed by Cursor Bugbot for commit bf4d2e6. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Document how to configure Mapbox tokens for mobile builds: distinguish runtime
pk.vs build-timesk.downloads token and where to set each for iOS, Android, and CI. Also note the Navigation SDK requires an active subscription and recommend using a shared org Mapbox account for token custody.~/.netrc—machine api.mapbox.com login mapbox password sk.…MAPBOX_DOWNLOADS_TOKENfor Gradle and in GitHub ActionsWritten for commit bf4d2e6. Summary will update on new commits.