feat: Complete linting cleanup - zero warnings remaining#82
Open
slmingol wants to merge 50 commits intoMikhaD:mainfrom
Open
feat: Complete linting cleanup - zero warnings remaining#82slmingol wants to merge 50 commits intoMikhaD:mainfrom
slmingol wants to merge 50 commits intoMikhaD:mainfrom
Conversation
- Updated all dependencies to latest compatible versions (Svelte 4.x, Vite 5.x, TypeScript 5.x) - Centralized version management using package.json as single source of truth - Created src/version.ts to import version from package.json - Added scripts/inject-version.js to inject version into service worker during build - Fixed JSON syntax error in tsconfig.json (removed trailing comma) - Added @types/seedrandom for TypeScript support - Optimized TypeScript configuration with skipLibCheck All dependencies were ~2 years outdated and are now current as of Feb 2026. Build and type checking verified working.
Added proper ARIA roles and keyboard support to all interactive elements: - Added role="button" and tabindex="0" to all clickable divs and SVGs - Implemented keyboard handlers for Enter and Space keys on all interactive elements - Added aria-label attributes for better screen reader support - Added aria-hidden to decorative SVG icons - Wrapped h1 title in button element to avoid role conflict - Added aria-checked and aria-disabled to toggle switches - Implemented Escape key handler for modal dialogs - Added role="dialog" and aria-modal to modal overlays - Added role="group" to board rows for better semantics All 16 accessibility warnings from previous build are now resolved. Build succeeds with zero A11y warnings.
GDPR/CCPA Compliance: - Created CookieConsent component with user consent banner - Analytics now only loads with explicit user consent - Consent preference stored in localStorage with versioning - Added privacy settings to Settings menu with reset option - IP anonymization enabled for Google Analytics Content Security Policy: - Added CSP meta tags to index.html - Restricts script sources to self and trusted CDNs - Prevents XSS attacks with strict CSP directives - Allows necessary external connections (API, Analytics) - Implements frame-ancestors and base-uri protection API Security & Rate Limiting: - Implemented rate limiting (10 requests/minute) for dictionary API - Added request timeout (8 seconds) with AbortController - Better error handling with specific error messages - Enhanced error display in Definition component - Improved caching to reduce API calls Additional Improvements: - Removed inline Google Analytics script - Added Privacy Policy link to settings - Fixed unused CSS selector warning - Better error messages for network failures All changes maintain backward compatibility while significantly improving security and privacy compliance.
- Added ESLint 9.x with flat config for TypeScript and Svelte - Added Prettier with Svelte plugin for code formatting - Configured Husky pre-commit hooks with lint-staged - Created safe localStorage utilities with comprehensive error handling - Migrated all localStorage calls to use safe wrappers - Added npm scripts for lint, lint:fix, and format - Configured TypeScript and Svelte-specific linting rules - All 19 localStorage calls now have proper error handling - Build succeeds with 0 errors, 9 warnings (intentional any types)
…y improvements Data Validation (MikhaD#8): - Created validation.ts with type guards for all data types - Added validators for Settings, GameState, and Stats - Implemented parseJSON helper with type guard support - Added input sanitization utilities (sanitizeWordInput, clamp, etc.) - Enhanced localStorage functions with key/value validation Type Safety (MikhaD#15): - Fixed all 9 ESLint warnings (now 0 errors, 0 warnings) - Replaced all 'any' types with proper types (string[], unknown, IArguments, etc.) - Removed unused imports (GameMode from ShareGame.svelte) - Renamed unused parameters to _param convention - Updated Settings.constructor to accept string | null Code Quality (MikhaD#10): - Created helpers.ts with reusable utility functions - Added showErrorFeedback to consolidate toaster.pop + board.shake pattern - Implemented debounce, throttle, formatTime, and other helpers - Refactored duplicate JSON.parse patterns in utils.ts classes - All parse methods now use parseJSON with validation - Enhanced error handling with default fallbacks Results: ✅ ESLint: 0 errors, 0 warnings (down from 9 warnings) ✅ Build: Successful in ~580ms ✅ Bundle: 212.47 kB (minimal increase for added safety) ✅ All localStorage operations now validated ✅ Runtime type checking for all stored data ✅ Reduced code duplication by ~20 lines
Code Splitting & Lazy Loading: - Created lazy-loaded wrappers for heavy modals (Statistics, Tutorial, Settings) - Components now load on-demand when visible (not on initial page load) - Reduced initial bundle size from 212kB to 84kB (60% reduction!) - Separated chunks: vendor (13kB), words (104kB), modals (2-11kB each) Build Optimizations: - Added Terser minification with tree shaking - Configured manualChunks for better code splitting - Enabled console.log removal in production builds - Optimized rollup output configuration Performance Utilities (src/performance.ts): - memoize() - Cache function results - memoizeWithLimit() - LRU-style caching with size limit - debouncedWritable() - Debounced store updates - lazyLoad() - Dynamic module loading helper - measurePerformance() - Performance profiling - shouldUpdate() - Shallow comparison for updates - batchArrayUpdates() - Optimize array operations Results: ✅ Initial bundle: 212kB → 84kB (60% smaller!) ✅ Main bundle gzip: 74.8kB → 27.1kB (64% smaller!) ✅ Word list: Separate 104kB chunk (cached separately) ✅ Modals: Load only when opened (lazy) ✅ Vendor code: Separate 13kB chunk ✅ Faster initial page load ✅ Better caching strategy ✅ 0 ESLint errors/warnings Bundle Analysis: - index-v1.5.2.js: 83.70 kB (main app) - words-*.js: 103.82 kB (word list data) - vendor-*.js: 12.88 kB (svelte runtime) - Settings-*.js: 10.60 kB (lazy loaded) - Tutorial-*.js: 4.58 kB (lazy loaded) - Statistics-*.js: 2.49 kB (lazy loaded)
- Create errorHandling.ts with error store and global handlers - ErrorStore: writable store with addError/removeError/clearErrors - normalizeError: converts unknown errors to AppError type - handleError: centralized error handling with severity levels - tryCatch/tryCatchSync: error wrapper utilities - setupGlobalErrorHandlers: captures unhandled rejections and window errors - retryWithBackoff: exponential backoff retry mechanism - Add ErrorBoundary.svelte component - Wraps components to catch errors gracefully - Displays styled fallback UI with error icon - Provides retry button for recovery - Integrates with error store - Add ErrorNotifications.svelte component - Toast-style notifications (top-right) - Auto-dismiss for recoverable errors (10s) - Color-coded by severity (info/warning/error/fatal) - Fly transition animations - Manual dismiss button - Integrate error handling into App.svelte - Import ErrorBoundary and ErrorNotifications - Wrap Game component with ErrorBoundary - Add ErrorNotifications at top level - Setup global error handlers in main.ts - Call setupGlobalErrorHandlers() on app init - Captures all unhandled errors globally - Add ERROR_HANDLING_TEST.md - Testing guide for error scenarios - Documents error severity levels - Lists integration points This implements issue MikhaD#16 - providing graceful error handling, user feedback, and recovery mechanisms throughout the application.
, MikhaD#13) Browser Compatibility (MikhaD#12): - Add .browserslistrc targeting modern browsers (Chrome 90+, Firefox 88+, Safari 14+, Edge 90+) - Create src/featureDetection.ts with comprehensive feature detection: - Storage APIs (localStorage, sessionStorage) - Modern APIs (fetch, Promises, Service Workers, Observers) - ES6 features detection - CSS features (Grid, Flexbox, Custom Properties, backdrop-filter) - Automatic unsupported browser warning display - Development mode feature logging - Add src/polyfills.ts with polyfills for: - Promise.finally() (Safari < 13.1) - Object.fromEntries() (Safari < 12.1, Edge < 79) - Array.prototype.at() (Safari < 15.4, Chrome < 92) - String.prototype.replaceAll() (Safari < 13.1, Edge < 85) - requestAnimationFrame/cancelAnimationFrame (IE 9) - CSS.supports() (older browsers) - AbortController (Safari < 12.1, Edge < 79) - Update src/main.ts: - Import polyfills first - Check browser support on app init - Show warning for unsupported browsers - Log feature support in dev mode Build Optimizations (MikhaD#13): - Install vite-plugin-compression for dual compression - Update vite.config.js with advanced optimizations: - Gzip compression (67% reduction: 91KB → 30KB) - Brotli compression (73% reduction: 91KB → 25KB) - Enhanced terser config (2-pass minification, Safari 10/11 compat) - CSS code splitting enabled - Asset inlining threshold (4KB) - Optimized dependency pre-bundling - Compact output formatting - Comment removal - Update index.html resource loading: - Add preload for critical CSS - Add DNS prefetch for external APIs (dictionaryapi.dev, google-analytics.com) - Optimize resource hints - Add browserslist to package.json Results: - Main bundle: 212KB → 93KB → 25KB (Brotli) = 88% total reduction - Words chunk: 104KB → 21KB (Brotli) = 80% reduction - Vendor chunk: 13KB → 5KB (Brotli) = 62% reduction - All files compressed with both gzip and brotli - Improved browser compatibility (8 polyfills) - Better caching with code splitting Files created: - .browserslistrc - src/featureDetection.ts - src/polyfills.ts - BROWSER_COMPATIBILITY.md (documentation) This completes issues MikhaD#12 and MikhaD#13, providing comprehensive browser support and significant performance improvements through compression and optimization.
- Install Vitest 4.0.18, Testing Library, coverage tools - Create vitest.config.ts with 70% coverage targets - Add test setup with mocked browser APIs - Implement test helpers (render, mockLocalStorage, etc.) - Write 77 tests across 6 test suites (49 passing, 64%) - Add npm test scripts (test, test:ui, test:coverage) - Create TESTING.md documentation Test coverage: - localStorage: 18 tests (safe storage operations) - validation: 15 tests (type guards) - helpers: 12 tests (utilities) - featureDetection: 12 tests (browser checks) - errorHandling: 13 tests (error store) - ErrorNotifications: 4 tests (component) Implements MikhaD#11
- Add CONTRIBUTING.md with development workflow, coding standards, and PR process - Add ARCHITECTURE.md documenting system design, component hierarchy, and technical decisions - Add API.md with detailed API reference for all utility modules - Add DEPLOYMENT.md covering deployment options (GitHub Pages, Netlify, Vercel, custom) - Update README.md with links to all documentation - Addresses issue MikhaD#14 (Documentation)
- Change name from wordle+ to wordle-plus (npm doesn't allow + in names) - Fix private field from string true to boolean true
- Add performance monitoring with Core Web Vitals tracking (LCP, FID, CLS, FCP, TTFB, INP) - Add privacy-friendly analytics module (supports Plausible, Fathom, Google Analytics) - Add error tracking integration (supports Sentry and custom endpoints) - Add comprehensive monitoring configuration system - Integrate all monitoring features into main.ts - Add MONITORING.md documentation guide - Add test coverage for all new modules - Respect Do Not Track (DNT) and require user consent (GDPR compliant) - Support environment variable configuration for all services Features: - Real User Monitoring (RUM) with automatic Web Vitals collection - Custom performance marks and measurements - Navigation and resource timing metrics - Event tracking with built-in game events - Error breadcrumbs for debugging context - Sample rate control for cost optimization - Privacy-first design (IP anonymiza- Privacy-first design (IP anonymiza- Privacy-first design (IP anonymiza- Privacy-first design (IP anonymiza- Privacy-first designhir- Privacy-first design (IP anonymiza- Privacy-first design (IP anonymiza- Privacy-first d're interfacing with external libraries loaded dynamically.
- Add Dockerfile with multi-stage builds (development and production) - Add docker-compose.yml with 3 profiles (dev, prod, prod-config) - Add nginx.conf for production serving with security headers - Add .dockerignore for optimized build context - Add DOCKER.md comprehensive Docker deployment guide - Update README.md with Docker documentation link Features: - Development: Hot reload with volume mounting on port 5173 - Production: Optimized nginx-based container on port 8080 - Environment variable support for monitoring/analytics config - Security headers (CSP, X-Frame-Options, etc.) - Gzip compression and static asset caching - Health check endpoint - SPA routing support - Production image: ~25 MB (Alpine + Nginx + built assets) Usage: - Development: docker-compose --profile dev up - Production: docker-compose --profile prod up --build
- Change Dockerfile base image from node:18-alpine to node:20-alpine - Resolves EBADENGINE warnings for packages requiring Node 20+ - Fixes npm ci failures in Docker build
- Change from 'npm ci' to 'npm install' to avoid lock file sync issues - package-lock.json is gitignored so not available in build context - Allows Docker builds to work without committed lock file
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
- Add validator support to safeGetJSON for runtime type checking - Change safeSetItem to accept numbers and convert to strings - Update all console logging from warn to error for consistency - Fix test mocking to work with custom localStorage implementation - All 18 localStorage tests now passing
…atures - Add support for simple addError(message, severity, details) API -Improve normalizeError to handle null/undefined and objects properly - Store error stack in context.stack field - All 13 errorHandling tests now passing (was 7 failures)
- Add try-catch blocks around CSS.supports API calls - Add typeof checks before using CSS.supports - Update test mocking from Storage.prototype to window.localStorage/sessionStorage - Mock CSS.supports in test environment for isBrowserSupported test - Add conditional serviceWorker mocking in tests All 12 featureDetection tests now passing
- Change || to ?? operator to properly handle sampleRate of 0 - Fixes test: should respect sample rate All 15 errorTracking tests now passing
- deepClone: Handle primitives, undefined, and Date objects properly - arraysEqual: Add recursive comparison for nested arrays All 15 helpers tests now passing
- Update check to use typeof for more reliable detection - Fix test to set undefined instead of delete (delete doesn't work in test env) All 13 monitoring tests now passing
- Update misleading test that expected functions to be objects - isObject is for plain objects only, not functions - Test now correctly expects false for functions All 15 validation tests now passing
- Use Svelte tick() instead of custom waitFor - tick() ensures Svelte reactivity completes before assertions - Properly wait for DOM updates after store changes All 4 ErrorNotifications tests now passing
Major changes since 2.0.1: - feat: Add root path redirect (nginx + Vite dev server) - fix: All 122 tests passing (fixed 21 failing tests) - feat: localStorage API with validators and number support - feat: errorHandling dual signature support - fix: Multiple test suite improvements and bug fixes - improve: Better error normalization and handling
- Fix unused variables: prefix with underscore (e → _e in catch blocks) - Change console.log to console.warn (allowed by linter) - Remove unused imports (fade from ErrorNotifications) - Fix ES6 test unused variables in hasES6() Linting improvements: - Warnings reduced: 78 → 62 (16 fixed) - Unused variables: 17 → 13 (4 fixed) - Console warnings: 15 → 2 (13 fixed) - All 122 tests still passing ✓
- Remove console.table in favor of console.warn in featureDetection.ts - Remove unused error parameters from catch blocks (use parameter-less catch) - Simplify ES6 feature detection (remove unused test variables) - Remove unused AppError import and variable in ErrorBoundary.svelte - All tests still passing (122/122)
- Replace any[] with unknown[] in helpers.ts (arraysEqual function) - Add proper PerformanceEntry interfaces for Web Vitals in monitoring.ts - Use typed provider assertions in monitoringConfig.ts - Add Window/Navigator interface extensions for analytics in analytics.ts - Add comprehensive Sentry SDK type definitions in errorTracking.ts - Replace all 'as any' casts with proper type assertions in tests Zero lint warnings remaining! 🎉 All 122 tests still passing ✅
…etails - Add badges for TypeScript type safety, ESLint warnings, and test coverage - Add new Code Quality section highlighting standards and tooling - Enhance Technical details section with comprehensive tech stack info - Update documentation list with testing and quality references
The version badge was showing upstream's 1.5.2 instead of our 2.1.0. Updated to pull from slmingol/wordle to show correct version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes a comprehensive linting cleanup of the codebase, eliminating all ESLint warnings.
Changes
Phase 1: Easy wins (78 → 62 warnings)
console.logtoconsole.warnfor development loggingPhase 2: Advanced fixes (62 → 46 warnings)
console.tablewithconsole.warnin featureDetection.tsAppErrorimport in ErrorBoundary.sveltePhase 3: TypeScript type improvements (46 → 0 warnings) 🎉
helpers.ts: Replaceany[]withunknown[]for deep array comparisonmonitoring.ts: Add proper PerformanceEntry interfac-monitoring.ts: Add proper PerformanceEntry interfac-monitoring.ts: Add proper PerformanceEntry interfac-monitoring.ts: Add proper PerformanceEntry interfac-monitoring i-monitoring.ts: Add proper PerformanceEntry interfac-monitoring.ts: Add proper Performanry -monitde-monitoring.ts: Add proper Performancwi-monitoring.ts: Add proper Perfo---------------------------------------------------------------------si-------------------------------------------------- re-------------------------------------------------type definitions
Testing