Updating variable names to be accurate#146
Open
akshaylive wants to merge 1 commit intoMilaNLProc:masterfrom
Open
Updating variable names to be accurate#146akshaylive wants to merge 1 commit intoMilaNLProc:masterfrom
akshaylive wants to merge 1 commit intoMilaNLProc:masterfrom
Conversation
Specifically, the existing code is treats some variables as variance while the variables are referred to as sigma, which is the standard notation of standard deviation. Fixing the variable names to avoid confusion.
Contributor
|
Thanks so much for this! I will work on fixing #144 and then merge all into main! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, the existing code is treats some variables as variance while the variables are referred to as sigma, which is the standard notation of standard deviation. Fixing the variable names to avoid confusion.
This commit resolves #145 .