fix: add missing model_type placeholder in _format_file (fixes #142)#153
Open
awanawana wants to merge 1 commit intoMilaNLProc:masterfrom
Open
fix: add missing model_type placeholder in _format_file (fixes #142)#153awanawana wants to merge 1 commit intoMilaNLProc:masterfrom
awanawana wants to merge 1 commit intoMilaNLProc:masterfrom
Conversation
Fixes MilaNLProc#142 The format string in _format_file() had 9 placeholders but 10 arguments were passed. The self.model_type argument was included in the format() call but had no corresponding placeholder in the string. Added mt_{} placeholder between tpv_{} and hs_{} to include the model_type in the directory name, which is important for distinguishing between different model configurations (e.g., CombinedTM vs ZeroShotTM). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_format_file()methodmt_{}placeholder forself.model_typeProblem
The format string had 9 placeholders but 10 arguments were passed:
This causes
self.model_typeto be silently ignored, meaning different model types (CombinedTM, ZeroShotTM) would save to the same directory.Solution
Added
mt_{}placeholder:Related
Fixes #142
🤖 Generated with Claude Code