Support multiple peer files from environment variable#133
Open
ceresnam wants to merge 1 commit intoMindFlavor:masterfrom
Open
Support multiple peer files from environment variable#133ceresnam wants to merge 1 commit intoMindFlavor:masterfrom
ceresnam wants to merge 1 commit intoMindFlavor:masterfrom
Conversation
PascalKu
requested changes
Mar 9, 2026
Collaborator
PascalKu
left a comment
There was a problem hiding this comment.
Nice improvement, thank you! Using std::env::split_paths is a good choice since it automatically handles platform-specific separators.
One thought from my side: the current implementation applies split_paths to all values, including those coming from the CLI. CLI arguments are already provided as separate values by clap, so this may unintentionally split paths that legitimately contain the separator character.
| extract_names_config_files: matches | ||
| .get_many("extract_names_config_files") | ||
| .map(|e: ValuesRef<'_, String>| e.into_iter().map(|a| a.to_owned()).collect()), | ||
| .get_many::<String>("extract_names_config_files") |
Collaborator
There was a problem hiding this comment.
This splits all inputs, including CLI arguments already parsed by clap. A CLI path containing : or ; could be incorrectly split. split_paths should only be applied when parsing the environment variable, not CLI-provided values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables specifying multiple WireGuard configuration files for the extract_names_config_files option using the PROMETHEUS_WIREGUARD_EXPORTER_CONFIG_FILE_NAMES environment variable.
It utilizes std::env::split_paths to automatically handle the correct OS-specific path list separator (: for Linux/Unix, ; for Windows).
Example (Environment Variable):
This correctly parses as:
This complements the existing command-line functionality:
Which also parses as: