Skip to content

Dev#170

Merged
sharrlotte merged 2 commits intomainfrom
dev
Mar 12, 2026
Merged

Dev#170
sharrlotte merged 2 commits intomainfrom
dev

Conversation

@sharrlotte
Copy link
Member

@sharrlotte sharrlotte commented Mar 12, 2026

Summary by CodeRabbit

  • New Features
    • Added search and filter capabilities to the filter dialog, enabling quick discovery of mods, sorts, tags, and blocks with an improved results display.
    • Servers are now automatically refreshed every 5 minutes to keep information current without manual intervention.

- Add search field to filter mods, blocks, and tags dynamically
- Implement debounced search to improve performance during typing
- Filter blocks by name based on search input
- Filter tags by name based on search input
- Update UI layout to accommodate search field
Schedule automatic server list updates every 5 minutes to ensure data remains current without requiring manual refreshes.
@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The PR bumps the mod version to v4.46.3-v8, implements a filter-driven UI overhaul in FilterDialog with text-based filtering and a dedicated results table using async token-guarded rebuilds, and adds a periodic 5-minute timer in ServerService to refresh the server list.

Changes

Cohort / File(s) Summary
Version Management
mod.hjson
Version string updated from v4.46.2-v8 to v4.46.3-v8.
Filter UI System
src/mindustrytool/features/browser/FilterDialog.java
Introduces text filter input and dedicated resultsTable replacing inline container flow. Adds setup() method for search bar construction, implements rebuildToken for async safety, and applies pre-filtering logic across ModSelector, SortSelector, TagSelector, and BlockSelector based on filterText input.
Server Refresh Scheduler
src/mindustrytool/services/ServerService.java
Adds periodic timer importing arc.util.Timer to schedule fetchServers calls every 5 minutes starting from initialization, alongside existing UI show-triggered refresh.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • feat: add periodic server list fetching #138: Both PRs modify ServerService to add periodic server-list fetching using Timer scheduling, with matching import and fetch logic.
  • Dev #169: Both PRs include mod.hjson version string updates, with this PR bumping to v4.46.3-v8.
  • Dev #143: Both PRs implement patch-level version bumps in mod.hjson as part of release cycles.

Poem

🐰 A filter blooms in dialogs bright,
With async tokens guarding right,
Servers wake each five-minute chime,
Version bumps mark time's design! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The pull request title 'Dev' is vague and generic, failing to convey meaningful information about the changeset which includes version bumps, UI overhaul, and server refresh scheduling. Replace the title with a descriptive summary of the main changes, such as 'Enhance filter dialog with search functionality and add periodic server refresh' or specify the primary focus if this is a development/staging branch.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sharrlotte sharrlotte merged commit 5d6f303 into main Mar 12, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant