refactor(PlayerConnectService): replace shared room future with local…

[sharrlotte]

… instances

remove the class-level roomFuture field, eliminate redundant isDone checks and future reset code, and use a new CompletableFuture for each method invocation

Summary by CodeRabbit

• Bug Fixes

  • Resolved an issue with concurrent request processing to ensure proper request isolation.

• Chores

  • Version updated to v4.57.5-v8.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 196e5d26-6ce4-4506-8fea-20334ed32927

📥 Commits

Reviewing files that changed from the base of the PR and between e0d0c3e and d7929da.

📒 Files selected for processing (2)

• mod.hjson
• src/mindustrytool/services/PlayerConnectService.java

---

Walkthrough

PlayerConnectService is refactored to use per-invocation CompletableFutures instead of a shared service-level field, eliminating potential async state conflicts. The mod version is incremented to v4.57.5-v8.

Changes

Async State Refactoring and Version Bump

Layer / File(s)	Summary
Per-invocation async state in PlayerConnectService src/mindustrytool/services/PlayerConnectService.java	Removed the shared roomFuture field from the service class. Updated findPlayerConnectRooms() to create a new per-call CompletableFuture, wire the HTTP request's error handler to complete that future exceptionally, and removed the finally block that previously reset the shared state after each request.
Version metadata update mod.hjson	Bumped mod version from v4.57.4-v8 to v4.57.5-v8.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• MindustryTool/MindustryToolMod#122: Shares the same mod.hjson version update change pattern.
• MindustryTool/MindustryToolMod#198: Also bumps the version field in mod.hjson to a different patch tag.
• MindustryTool/MindustryToolMod#78: Updates the mod.hjson manifest version field in the same way.

Poem

🐰 A future per call, no sharing state,
Async flows clean, no race conditions to wait,
Shared ghosts removed, the code runs true,
Version bumped bright—v4.57.5 for you!

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}