Skip to content

Allow manager to view roles (workspace)#3284

Open
timothycarambat wants to merge 5 commits intomasterfrom
3282-manager-view-models-workspace
Open

Allow manager to view roles (workspace)#3284
timothycarambat wants to merge 5 commits intomasterfrom
3282-manager-view-models-workspace

Conversation

@timothycarambat
Copy link
Copy Markdown
Member

@timothycarambat timothycarambat commented Feb 19, 2025

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #3282

What is in this change?

  • Allow the manager role to view the models in a dropdown while on workspace settings.
  • Additional security on customModels to only persist a passed ApiKey when the role is null (no auth mode) or the role is explicitly ROLE.admin. null role is okay here since to get to this function the middleware does the proper auth checks.

TODO:

  • If I am a manager and I attempt to pick an LLM that has not been configured, the credential modal should not appear since that update will fail and the details will not persist.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@timothycarambat timothycarambat added the PR:needs review Needs review by core team label Feb 26, 2025
@Yaronbaroz18
Copy link
Copy Markdown

any news for this issues?

@timothycarambat timothycarambat removed their assignment Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-team-only PR:needs review Needs review by core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Allow manager role to view models for known providers, but not update

3 participants