GEOPY-2898: Investigate edge cells recovered with DC2D inversions#423
Open
domfournier wants to merge 5 commits into
Open
GEOPY-2898: Investigate edge cells recovered with DC2D inversions#423domfournier wants to merge 5 commits into
domfournier wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR investigates/mitigates edge-cell artifacts in DC2D inversions by constraining boundary cells during optimization, then updates run-tests and dependency locks to reflect the new inversion behavior.
Changes:
- Override 2D driver optimization to keep boundary (and bottom-row) cells fixed at the starting model via bounds + active-set gradient scaling.
- Update DC2D run-tests to validate boundary-cell behavior and refresh expected inversion metrics.
- Update joint-surveys option validation to derive physical property from each group’s driver class; refresh dependency/lock files (including a git-based
mira-simpegpin).
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run_tests/driver_dc_2d_test.py | Updates target metrics and adds an assertion that boundary cells remain at the starting value. |
| tests/run_tests/driver_dc_2d_rotated_gradients_test.py | Updates expected target metrics for rotated-gradient DC2D run. |
| simpeg_drivers/joint/joint_surveys/options.py | Determines per-group physical property via the group’s run_command driver class rather than group options. |
| simpeg_drivers/electricals/induced_polarization/two_dimensions/inversion.py | Reorders base classes so Base2DDriver behavior (e.g., optimization override) takes precedence in MRO. |
| simpeg_drivers/electricals/direct_current/two_dimensions/inversion.py | Same base-class reorder for DC2D inversion driver. |
| simpeg_drivers/electricals/base_2d.py | Introduces 2D-specific optimization override and logic to identify and freeze edge/bottom cells. |
| pyproject.toml | Switches mira-simpeg dependency from version range to a git ref (GEOPY-2898 branch). |
| py-3.13.conda-lock.yml | Regenerates lock to reflect dependency changes and updated resolution. |
| py-3.12.conda-lock.yml | Regenerates lock to reflect dependency changes and updated resolution. |
| environments/py-3.13-win-64.conda.lock.yml | Updates rendered env lock (incl. pip section now pointing at git mira-simpeg). |
| environments/py-3.13-win-64-dev.conda.lock.yml | Same for dev env. |
| environments/py-3.13-linux-64.conda.lock.yml | Same for linux env. |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Same for linux dev env. |
| environments/py-3.12-win-64.conda.lock.yml | Same for py3.12 win env. |
| environments/py-3.12-win-64-dev.conda.lock.yml | Same for py3.12 win dev env. |
| environments/py-3.12-linux-64.conda.lock.yml | Same for py3.12 linux env. |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Same for py3.12 linux dev env. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #423 +/- ##
==================================================
+ Coverage 90.55% 90.57% +0.02%
==================================================
Files 110 110
Lines 6508 6539 +31
Branches 817 822 +5
==================================================
+ Hits 5893 5923 +30
Misses 410 410
- Partials 205 206 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2898 - Investigate edge cells recovered with DC2D inversions