feat: add retired information to contract agreement api#380
Draft
feat: add retired information to contract agreement api#380
Conversation
ab7a9fd to
cc08dca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
/contractagreement/request-enhancedendpoint, that behaves in the same exact way/contractagreement/requestdoes plus adding information about eventual retirement.This will make the frontend snappier because there won't be the need to do 2 calls anymore.
Attributes added:
isRetired: booleanretiredAt: numberretirementReason: stringHow
It looks a bit hacky, but what I did is:
EnhancedAgreementthat uses the originalContractAgreementtransformerNotes
transferCountinformation has not been added yet, because it would require an additional chunk of work.Let's validate this first and do the rest later.