feat: stabilize ACLs cleanup by getting the admin properties directly from the DataFlow#392
Merged
feat: stabilize ACLs cleanup by getting the admin properties directly from the DataFlow#392
Conversation
… from the DataFlow
hciniramy
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Solves TODO about ACLs deletion:
currently there's an in-memory map to store the admin properties, but this is not enough in the case the connector gets restarted.
The solution has be to inject the
DataPlaneStoreand fetch theDataFlowagain to get the vault key where the properties are stored in the vault.Note
To solve it in a cleaner way, an upstream development should be required, but given that the data-plane is deprecated, that won't happen likely, it will be much easier since we'll maintain the Data-Plane by ourselves.