Skip to content

Conversation

@QuadnucYard
Copy link
Contributor

@QuadnucYard QuadnucYard commented Aug 20, 2025

New features:

  • Added a command to open a temporary file (like the AST view) to inspect the value under the cursor.
  • Added a command link to the hover tooltip to quickly open the value view. (problem: this link can be trimmed if the values are too long)
image image image

Some problems:

  • The entry file does not follow the active one. Without being pinned, the values are not traced, and thus no value is displayed.
  • The number of displayed values is hard-limited by typst tracking, but we do not know if values are truncated.

@QuadnucYard
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature to view the full value of an expression under the cursor. The implementation looks good overall, with a new command and a custom view in VSCode. I've identified a few areas for improvement:

  • A bug in associated_path that prevents correct context resolution for the ShowFullValue query, which you've also noted as a problem. I've suggested a fix.
  • A very large SIZE_LIMIT constant that could cause performance issues. I've recommended reducing it.
  • The VSCode extension sends requests on every keystroke, which can be inefficient. I've suggested debouncing these requests to improve performance.
    With these changes, the feature should be more robust and performant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant