add ToolCallLimits capability on PydanticAIBaseAgent via scalar wiring#78
Open
sanzog03 wants to merge 1 commit intofeature/pydantic_ai_base_agentfrom
Open
add ToolCallLimits capability on PydanticAIBaseAgent via scalar wiring#78sanzog03 wants to merge 1 commit intofeature/pydantic_ai_base_agentfrom
sanzog03 wants to merge 1 commit intofeature/pydantic_ai_base_agentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills in
PydanticAIBaseAgent._build_capabilities_from_scalars()— Consumers who setmax_tool_iterationsormax_tool_callson the config now get a hard runtime cap enforced during the model-request loop and tool-executionpath, with AKD's existing
UsageLimitExceededfamily of errors surfacing cleanly through pydantic_ai'sUnexpectedModelBehavior.What it does
PydanticAIBaseAgentrespectmax_tool_iterationsandmax_tool_callsfrom the inheritedBaseAgentConfig— the ReAct loop no longer runs unbounded.MaxToolIterationsExceeded/MaxToolCallsExceeded(both subclasses ofUsageLimitExceeded), mirroring the semantics the legacy OpenAI-basedBaseAgentalready exposes._build_capabilities_from_scalars, callingsuper(), and appending (the extension pattern is now pinned by a test).PydanticAIBaseAgentConfig— both scalars come in fromBaseAgentConfigunchanged.Files changed
akd_ext/agents/_base/pydantic_ai/_capabilities.py— holdsToolCallLimits(Hooks factory, closure state, two conditional lifecycle callbacks).-
akd_ext/agents/_base/pydantic_ai/_base.py— importsToolCallLimits;_build_capabilities_from_scalarsbody replaced with themax_tool_iterations/max_tool_calls.-
tests/agents/test_base_pydantic.py— adds four tests under ToolCallLimits" section; restores one field on_EchoConfig(enable_extra_capability: bool) that the subclass-extension test needs.Testing
Run the test suite (hermetic; no network, no model keys):