Conversation
…22.04 - support gpus with latest cuda compute capability
- last version with base py38 support available for download
- Version 3.7 was not found in the local cache - Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04. - The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
- default anaconda repo issues
docker: bump base os to ubuntu 22.04 with cuda 12.2 and cudnn 8
- and manual ad-hoc trigger
- no submodules needed for ci image
ci: build ci runner image in github actions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the deepFCD project's environment and CI/CD infrastructure by upgrading from CUDA 10/Ubuntu 18.04 to CUDA 12.2/Ubuntu 22.04, switching from Miniconda to Miniforge for package management, and enhancing GitHub Actions workflows for better efficiency and maintainability.
- Upgraded base Docker images to use CUDA 12.2 with Ubuntu 22.04 for better hardware compatibility
- Replaced Miniconda with Miniforge across all Docker images and documentation
- Enhanced CI/CD workflows with manual triggers, improved caching, and separate jobs for main and CI images
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Dockerfile | Upgraded to CUDA 12.2/Ubuntu 22.04 base image and replaced Miniconda with Miniforge |
| ci/runner.Dockerfile | Modernized CI runner image with CUDA 12.2, simplified dependencies, and Miniforge installation |
| ci/start-runner.sh | Updated PATH to reflect Miniforge installation location |
| ci/runner.docker-compose.yml | Updated image references and runner version, adjusted GPU device configuration |
| README.md | Updated installation instructions to recommend Miniforge over Miniconda with specific versions |
| .github/workflows/*.yml | Enhanced workflows with manual triggers, caching, disk space management, and separate CI image builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant updates to the Docker images, CI/CD workflows, and documentation to modernize the environment, improve reproducibility, and streamline the build and test processes. The most important changes include upgrading the base images to CUDA 12.2/Ubuntu 22.04, switching from Miniconda to Miniforge for Conda environments, refactoring GitHub Actions workflows for more flexibility and efficiency, and updating documentation and scripts to reflect these changes.
Docker and Environment Modernization:
Dockerfileandci/runner.Dockerfileto usenvidia/cuda:12.2.2-cudnn8-devel-ubuntu22.04as the base image instead of the older CUDA 10/Ubuntu 18.04 images, ensuring compatibility with newer hardware and software stacks. [1] [2]pygpuversions, and ensured dependencies are installed in isolated environments. [1] [2]CI/CD Workflow Refactoring:
workflow_dispatch), separate jobs for main and CI Docker images, and improved disk space management before builds. [1] [2]mainanddevbranches, switching tocurlfor dataset downloads, and running tests within the correct Conda environment. [1] [2]Documentation and Usability Improvements:
README.mdto recommend Miniforge over Miniconda, clarified Python and dependency versions, and revised setup instructions to match the new environment setup. [1] [2] [3]ci/runner.docker-compose.ymlto use the new image naming and updated runner version and device IDs for compatibility with the new base image.ci/start-runner.shto reflect the switch to Miniforge.