Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly refactors and modernizes the
tests/test_deepFCD.pyunit tests for the deepFCD module. The main improvements include restructuring the test class for better organization, consolidating repeated logic into helper methods, improving parameterization and test setup, and enhancing test coverage for image I/O operations. The changes also streamline the code by removing redundant code and clarifying test intent.Test suite refactor and modernization:
TestModule_deepFCDtoTestDeepFCD, usingsetUpClassandsetUpto centralize environment and file path setup, making the tests more maintainable and easier to configure for different environments._test_image_comparisonhelper method, reducing code duplication and clarifying test intent.Expanded and improved image I/O tests:
test_image_io_operationsmethod that tests reading, writing, and verifying physical space consistency and data integrity for different pixel types, as well as proper cleanup of temporary files.test_image_header_infoto robustly