rename temporary column to something less likely to be used#1846
Open
nv-alaiacano wants to merge 6 commits intoNVIDIA-Merlin:mainfrom
Open
rename temporary column to something less likely to be used#1846nv-alaiacano wants to merge 6 commits intoNVIDIA-Merlin:mainfrom
nv-alaiacano wants to merge 6 commits intoNVIDIA-Merlin:mainfrom
Conversation
karlhigley
approved these changes
Jun 21, 2023
rjzamora
previously approved these changes
Jun 21, 2023
Collaborator
rjzamora
left a comment
rjzamora
left a comment
There was a problem hiding this comment.
Thanks @nv-alaiacano !
Collaborator
|
Ah - Looks like we also make the |
rjzamora
dismissed
their stale review
We should probably coordinate with a change to core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal/temporary column "labels" is a common thing for people to use. Columns with this name will not get categorified. I changed it to
__labels_tmp.