Vulkan: allocation callback fix - #139
Open
xexaaron wants to merge 1 commit into
Open
Conversation
…scriptor set layout owned by the device.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulkan: use allocation callbacks when destroying pipeline cache and descriptor set layout owned by the device.
Reason: The nrvhi::vulkan::Device uses the custom allocator for creating these objects but not for destroying them. This produces validation errors during Device destruction.
Validation Errors:
vkDestroyPipelineCache(): Custom allocator not specified while destroying VkPipelineCache obj 0xd000000000d but specified at creation.
vkDestroyDescriptorSetLayout(): Custom allocator not specified while destroying VkDescriptorSetLayout obj 0xe000000000e but specified at creation.