[TRTLLM-11492][fix] Replace blocking fill loop with non-blocking can_forward gate in benchmark disagg mode#12208
Draft
chienchunhung wants to merge 1 commit intoNVIDIA:mainfrom
Draft
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #38922 [ run ] triggered by Bot. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Improve disagg benchmark logic and add test coverage.
The benchmark disagg fill loop in _prepare_and_schedule_batch blocked the GEN executor until all requests were fetched, starving KV transfer processing and causing deadlocks when the CTX server had limited KV cache. Replace the blocking loop with a non-blocking can_forward gate in both _executor_loop and _executor_loop_overlap. Each main-loop iteration now fetches available requests, services KV transfers, and checks readiness via _is_benchmark_disagg_fill_complete, allowing incremental progress.
This PR is co-worked with Cursor agent.
Test Coverage
Added a new unit test file "tests/unittest/_torch/executor/test_benchmark_disagg.py".
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.