Open
Conversation
This comment has been minimized.
This comment has been minimized.
jrhemstad
reviewed
Feb 6, 2026
| __stream.get()); | ||
|
|
||
| { | ||
| __allocation_guard<_OffsetType, decltype(__resource)> __guard{__stream, __resource, __num_bytes}; |
Collaborator
There was a problem hiding this comment.
question: Can't this just be a cuda::buffer?
Contributor
Author
There was a problem hiding this comment.
Unfortunately not, the buffer owns the resource, we only want a reference
Collaborator
There was a problem hiding this comment.
That can't be right. If we designed cuda::buffer in a way that it can't be used for temporary allocation like this, then something fundamental is wrong. Why can't I pass a resource_ref into the buffer ctor?
miscco
changed the title
cuda::std::copy_if
miscco
force-pushed
the
parallel_copy_if
branch
2 times, most recently
from
a77c254 to
4e79b30
Compare
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
parallel_copy_if
branch
from
4e79b30 to
d2bb751
Compare
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
parallel_copy_if
branch
from
d2bb751 to
a89d4b0
Compare
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
parallel_copy_if
branch
2 times, most recently
from
8f8b8a2 to
c2bd9bf
Compare
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
parallel_copy_if
branch
from
c2bd9bf to
9217507
Compare
This comment has been minimized.
This comment has been minimized.
This implements the copy_if algorithm for the cuda backend. * std::copy_if see https://en.cppreference.com/w/cpp/algorithm/copy_if.html It provides tests and benchmarks similar to Thrust and some boilerplate for libcu++ The functionality is publicly available yet and implemented in a private internal header Fixes NVIDIA#7517
miscco
force-pushed
the
parallel_copy_if
branch
from
9217507 to
ba84c03
Compare
Contributor
😬 CI Workflow Results🟥 Finished in 1h 10m: Pass: 86%/95 | Total: 15h 55m | Max: 42m 55s | Hits: 98%/214832See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the copy_if algorithm for the cuda backend.
It provides tests and benchmarks similar to Thrust and some boilerplate for libcu++
The functionality is publicly available yet and implemented in a private internal header
Fixes #7517