docs(reasoner): clarify raw vLLM video sampling - #337
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra_bodyform and equivalent raw/v1/chat/completionsJSONfpsanddo_sample_framesbelong insidemm_processor_kwargs, not as standalone top-level chat-completion fieldsWhy
Issue #190 reports weak physical-plausibility classification while sending
fpsanddo_sample_framesas top-level fields in a rawrequestspayload. The current Reasoner prompt guide documents video sampling throughextra_body={"mm_processor_kwargs": ...}for the OpenAI client, but the vLLM quickstart does not show the equivalent raw JSON shape.That distinction matters for motion-dependent tasks such as physical plausibility analysis because frame sampling determines which temporal events are presented to the Reasoner. This change makes the raw HTTP configuration explicit next to the vLLM quickstart.
Validation
Documentation-only change. Cross-checked against the current Reasoner prompt guide's
mm_processor_kwargssampling configuration and the request shown in #190.Addresses #190