fix: remove terminated extension services from instance config#620
Merged
hanyux-nv merged 1 commit intoNVIDIA:mainfrom Mar 20, 2026
Merged
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-18 17:51:09 UTC | Commit: 08d2549 |
🛡️ Vulnerability Scan🚨 Found 72 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-18 17:51:11 UTC | Commit: 08d2549 |
hanyux-nv
force-pushed
the
fix_es_terminated_not_removed
branch
3 times, most recently
from
8211e06 to
56acaf4
Compare
ianderson-nvidia
approved these changes
Mar 19, 2026
Signed-off-by: Felicity Xu <hanyux@nvidia.com>
hanyux-nv
force-pushed
the
fix_es_terminated_not_removed
branch
from
56acaf4 to
7cbe17d
Compare
bcavnvidia
approved these changes
Mar 20, 2026
srinivasadmurthy
pushed a commit
to srinivasadmurthy/bare-metal-manager-core
that referenced
this pull request
Mar 20, 2026
…A#620) ## Description Fixes a gap where extension services marked for removal were not cleaned up from instance config even after all DPUs reported successful termination. Previously, terminated extension service cleanup was only executed in the `WaitingForExtensionServicesConfig` instance state; however, extension service config updates do not transition the machine out of Ready (only tenant state moves to `Configuring`). This change adds instance extension service config cleanup in the `Ready` state so terminated services can be cleaned up. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) Signed-off-by: Felicity Xu <hanyux@nvidia.com> Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a gap where extension services marked for removal were not cleaned up from instance config even after all DPUs reported successful termination.
Previously, terminated extension service cleanup was only executed in the
WaitingForExtensionServicesConfiginstance state; however, extension service config updates do not transition the machine out of Ready (only tenant state moves toConfiguring). This change adds instance extension service config cleanup in theReadystate so terminated services can be cleaned up.Type of Change
Related Issues (Optional)
Breaking Changes
Testing