fix: Do not allow tls connections to Vault without TLS Verification#652
Draft
ianderson-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
Draft
fix: Do not allow tls connections to Vault without TLS Verification#652ianderson-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
ianderson-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-20 01:03:31 UTC | Commit: b03bfd6 |
🛡️ Vulnerability Scan🚨 Found 72 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-20 01:03:37 UTC | Commit: b03bfd6 |
Fixes NVBug 5999702 Signed-off-by: Ian Anderson <ianderson@nvidia.com>
ianderson-nvidia
force-pushed
the
vault_tls_verification
branch
from
b03bfd6 to
c3878d8
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
hwadekar-nv
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raise an error if the Vault root CA is not found rather than continue without TLS verification
Fixes NVBug 5999702