Draft
Conversation
Owner
|
Hi, |
Author
|
I see how it could cause issues, however I think that it wouldn't. To stay backwards compatible adding __cpp_deduction_guides check would do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Naios
This is a real quick deduction guide implementation that worked for me but is really raw.
I am open to collaboration as I'm not at all familiar with the codebase.
What was a problem?
The code that didn't compile:
Now compiles.
How this PR fixes the problem?
fu2::function,fu2::unique_functionandfu2::function_viewwere template aliases which limited the CTAD.Now all of them are kind of strong typedef'ed with addition of deduction guides.
Check lists (check
xin[ ]of list items)Additional Comments (if any)
I would really appreciate some CONTRIBUTING.md or any kind of guidance.