Add checks module and cleanup code, prep for labels module#25
Merged
Add checks module and cleanup code, prep for labels module#25
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 50.02% 50.75% +0.72%
==========================================
Files 39 40 +1
Lines 1777 1795 +18
==========================================
+ Hits 889 911 +22
+ Misses 888 884 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are many places in the code where it makes sense to check types of verify required columns are provided for particular routines. Instead of having duplicate code everywhere to raise these errors, there is now a new
_checksmodule. This is not intended to be exposed to the user and thus is not imported into the main__init__. Rather, the checks are imported in functions locally where they are needed. Presently, there are checks to do the following:Datasetfor required columnsTrueto avoid conflicting settings/optionsType of change
Key checklist:
$ nox -s linter [-- format]$ nox -s codespell [-- write]$ nox -s testsFurther checks:
$ nox -s docs.