upgrade lua-resty-session to v4 and lua-resty-openidc to 1.8#702
Open
jtmkrueger wants to merge 6 commits intomainfrom
Open
upgrade lua-resty-session to v4 and lua-resty-openidc to 1.8#702jtmkrueger wants to merge 6 commits intomainfrom
jtmkrueger wants to merge 6 commits intomainfrom
Conversation
…an up numbers strewn about
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves 18F/api.data.gov#697
There's a number of things that had to happen here in order to get these upgrades going
I tried to be verbose with comments in test/support/api_umbrella_test_helpers/admin_auth.rb, because it's kinda math-heavy. Leaned on built in libs as much as possible, but wanted to be clear about what's happening in that stuff.