Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a geothermal “physics loss” implementation (conductive heat transfer residual + regularizers) inspired by the referenced STM paper, along with unit tests for the new loss terms.
Changes:
- Implement
GeothermalConductiveHeatTransferLoss,GeothermalPositiveTemperatureGradientLoss, andGeothermalMohoBCLossinsup3r/utilities/loss_metrics.py - Add synthetic-data tests covering geothermal heat transfer, positive gradient, and Moho BC losses
- Refactor/extend some loss-metric utilities (e.g., reshaping helper) and update existing loss formatting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
sup3r/utilities/loss_metrics.py |
Adds geothermal-specific loss classes and a helper for reshaping depth features for vertical derivatives. |
tests/utilities/test_loss_metrics.py |
Adds unit tests validating behavior and error handling for the new geothermal loss implementations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Ok, whew. Tests are now passing. Still good to go on this PR @bnb32? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add (my best interpretation) of the geothermal physics loss from the STM paper.