Conversation
| self._user_agent = self._const['user_agent'] | ||
| self._codes = self._const['codes'] | ||
| self._scheme_codes = self.get_scheme_codes().keys() | ||
| self._session = session |
There was a problem hiding this comment.
If the session is None then this assignment would be directly contradictory to line 36
| Mutual Funds in India | ||
| """ | ||
| def __init__(self): | ||
| def __init__(self, session=None, cache=None): |
There was a problem hiding this comment.
Why do we require to pass a session and cache while creating an object if not None?
I guess it can be handled internally.
|
session=None is how it is handled in yfinance. We can handle it internally, but I would say that these are not handled internally even in yfinance either, so remain similar to it. In fact, looking at the code I see the cache=None is also handled explicitly in yfinance, so I will remove the unecessary if there. |
|
First of all let me know Why do you require a session and cache? If you are using this library in any personal project then these changes would be part of that project only or we can directly use yfinance instead of mftool. |
|
I am using it in my personal capacity already, of course, since I want to rate limit aggresively and I just think it is a good design to re-use existing framework and be compatiable with existing APIs. Hence the PR :) Ultimately your call... I personally don't see any technical issue. |
2 participants
Add support for session and cache parameters