This repository was archived by the owner on Nov 2, 2018. It is now read-only.
Calculate potential values at startup#2886
Open
nielscastien wants to merge 2 commits intoNebulousLabs:masterfrom
Open
Calculate potential values at startup#2886nielscastien wants to merge 2 commits intoNebulousLabs:masterfrom
nielscastien wants to merge 2 commits intoNebulousLabs:masterfrom
Conversation
start-up loop. Together with ContractCount and LockedStorageCollateral these are the metrics of h.FinancialMetrics that tend to increase too much over time because of a bug. This change will reset all metrics to the correct value at start-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will extend the previous one where the locked storage collateral is re-calculated at start-up.
On my host this gives more sane (i.e. smaller) values that are more in line with the revenues. The impact will be proportional with the age of the host.