WIP: CMakeLists.txt: add install rules#196
Draft
SomeoneSerge wants to merge 1 commit intoNelarius:masterfrom
Draft
WIP: CMakeLists.txt: add install rules#196SomeoneSerge wants to merge 1 commit intoNelarius:masterfrom
SomeoneSerge wants to merge 1 commit intoNelarius:masterfrom
Conversation
SomeoneSerge
commented
Apr 13, 2024
Comment on lines
+120
to
+123
| install( | ||
| FILES imnodes.h imnodes_internal.h | ||
| COMPONENT Development | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}) |
Author
There was a problem hiding this comment.
I'm surprised to see this, given that the documentation claims "include" is the default/fallback value for the variable: https://cmake.org/cmake/help/latest/command/install.html#signatures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MInimal set of changes required for NixOS/nixpkgs#303682