installed linting #199
Open
installed linting #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
❌ Deploy Preview for radiant-sprinkles-d2960e failed. Why did it fail? →
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets up linting infrastructure for an Astro project by installing ESLint and Prettier with proper TypeScript and Astro support.
- Adds a comprehensive lint script that runs Prettier for formatting and ESLint for code quality checks
- Updates ESLint and related dependencies to more recent versions
- Configures ESLint for TypeScript and Astro files with appropriate parsers and rules
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds lint script and updates ESLint dependencies with TypeScript support |
| eslint.config.js | Creates modern flat config for ESLint with TypeScript and Astro file support |
| .eslintrc.cjs | Adds legacy ESLint configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -0,0 +1,42 @@ | |||
| import js from '@eslint/js'; | |||
There was a problem hiding this comment.
Both eslint.config.js and .eslintrc.cjs configuration files are present. Having duplicate ESLint configurations can cause conflicts and confusion. Consider removing one of these files - typically the legacy .eslintrc.cjs should be removed in favor of the modern flat config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.