afpd: reap idle Spotlight queries to prevent resource leaks#2901
Merged
afpd: reap idle Spotlight queries to prevent resource leaks#2901
Conversation
🤖 Augment PR SummarySummary: This PR prevents Spotlight query objects in Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
Clients that disconnect or crash without sending closeQueryForContext leave server-side query objects allocated indefinitely. Add a MAX_SL_QUERY_IDLE_TIME (60 s) constant and slq_idle_cleanup(), which scans the active query list on every Spotlight RPC and cancels or destroys any query not polled within the idle window. The idle timer (slq_time) is reset on each fetchQueryResultsForContext call so actively-polled queries are not reaped. The cleanup runs alongside the existing slq_cancelled_cleanup() in afp_spotlight_rpc().
rdmark
force-pushed
the
rdmark-reap-spotlight
branch
from
42234e9 to
4f5fddc
Compare
|
Contributor
🔥 Spectest (AFP 3.4) - Flamegraph (AFP_ASSERT active)Commit: 🔥 Open interactive Flamegraph (SVG) 🔝 Top 10 leaf functions
|
andylemin
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients that disconnect or crash without sending closeQueryForContext leave server-side query objects allocated indefinitely. Add a MAX_SL_QUERY_IDLE_TIME (60 s) constant and slq_idle_cleanup(), which scans the active query list on every Spotlight RPC and cancels or destroys any query not polled within the idle window.
The idle timer (slq_time) is reset on each fetchQueryResultsForContext call so actively-polled queries are not reaped. The cleanup runs alongside the existing slq_cancelled_cleanup() in afp_spotlight_rpc().