fix(tests): use glob instead of regex in nix-shell test#15254
Open
roberth wants to merge 1 commit intoNixOS:masterfrom
Open
fix(tests): use glob instead of regex in nix-shell test#15254roberth wants to merge 1 commit intoNixOS:masterfrom
roberth wants to merge 1 commit intoNixOS:masterfrom
Conversation
The NIX_BUILD_TOP test used regex matching with an unquoted path variable. When the path contains `+` (or other regex operators), the test fails because `+` is interpreted as a quantifier rather than a literal character. Glob matching handles these characters correctly.
github-actions
bot
added
the
with-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NIX_BUILD_TOPtest used regex matching with an unquoted path variable. When the path contains+(or other regex operators), the test fails because+is interpreted as a quantifier rather than a literal character. Glob matching handles these characters correctly.Motivation
I use worktree directories with a
+in them.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.