Open
Conversation
This allows doing `builtins.getFlake ./subflake` instead of ugly hacks.
github-actions
bot
added
the
with-tests
roberth
approved these changes
Feb 18, 2026
| lockFlake(const Settings & settings, EvalState & state, const SourcePath & flakeDir, const LockFlags & lockFlags) | ||
| { | ||
| /* We need a fake flakeref to put in the `Flake` struct, but it's not used for anything. */ | ||
| auto fakeRef = parseFlakeRef(state.fetchSettings, "flake:get-flake"); |
Member
There was a problem hiding this comment.
I suppose this simply might not fly and isn't worth changing, but if it does work,
Suggested change
| auto fakeRef = parseFlakeRef(state.fetchSettings, "flake:get-flake"); | |
| auto fakeRef = parseFlakeRef(state.fetchSettings, "internal:get-flake"); |
Member
Author
There was a problem hiding this comment.
Unfortunately that doesn't work because it's not a support input scheme:
error: input 'internal:get-flake' is unsupported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This allows getting a subflake from the current source tree by doing
instead of the hacky
Based on DeterminateSystems#338 and part of DeterminateSystems#337.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.