Skip to content

global-platform-pro: convert to mavenfod#238745

Merged
wegank merged 1 commit intoNixOS:masterfrom
wegank:global-platform-pro-mavenfod
Jun 20, 2023
Merged

global-platform-pro: convert to mavenfod#238745
wegank merged 1 commit intoNixOS:masterfrom
wegank:global-platform-pro-mavenfod

Conversation

@wegank
Copy link
Copy Markdown
Member

@wegank wegank commented Jun 20, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Copy Markdown
Member Author

wegank commented Jun 20, 2023

@ofborg build global-platform-pro global-platform-pro.passthru.tests

@wegank wegank marked this pull request as draft June 20, 2023 11:34
@wegank wegank force-pushed the global-platform-pro-mavenfod branch from 7cd74a2 to 13ded18 Compare June 20, 2023 11:52
@wegank wegank marked this pull request as ready for review June 20, 2023 11:52
@ofborg ofborg Bot requested a review from Ekleog June 20, 2023 13:11
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 20, 2023
@wegank
Copy link
Copy Markdown
Member Author

wegank commented Jun 20, 2023

Result of nixpkgs-review pr 238745 run on aarch64-darwin 1

1 package built:
  • global-platform-pro

@wegank wegank merged commit 10ee9d0 into NixOS:master Jun 20, 2023
@wegank wegank deleted the global-platform-pro-mavenfod branch June 20, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant