Skip to content

[16.0][ADD] crm_partner_contact_role#588

Open
AungKoKoLin1997 wants to merge 1 commit intoOCA:16.0from
qrtl:16.0-add-crm_partner_contact_role
Open

[16.0][ADD] crm_partner_contact_role#588
AungKoKoLin1997 wants to merge 1 commit intoOCA:16.0from
qrtl:16.0-add-crm_partner_contact_role

Conversation

@AungKoKoLin1997
Copy link
Copy Markdown

@AungKoKoLin1997 AungKoKoLin1997 commented Jul 23, 2024 •
edited
Loading

This PR adds role_ids to the crm.lead model and propagates them to the res.partner record when it is created from crm.lead.

Related: OCA/partner-contact#1812
@qrtl QT4695

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-crm_partner_contact_role branch from b5e74ca to 69bbce7 Compare August 9, 2024 03:09
damdam-s
damdam-s approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@damdam-s damdam-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yostashiro
yostashiro reviewed Oct 7, 2024
View reviewed changes
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-crm_partner_contact_role branch from 69bbce7 to 6e79b17 Compare October 11, 2024 02:17
yostashiro
yostashiro approved these changes Oct 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, otherwise LGTM.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 11, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

2 similar comments
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 11, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 11, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997
Copy link
Copy Markdown
Author

AungKoKoLin1997 commented Oct 24, 2024

@oca/crm-maintainers
Is it possible to take a look at this PR?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-crm_partner_contact_role branch from 6e79b17 to 0f9df21 Compare February 6, 2025 09:07
BhaveshHeliconia
BhaveshHeliconia reviewed Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moitabenfdz
Copy link
Copy Markdown

moitabenfdz commented Jul 31, 2025

@simahawk @gurneyalex
Can you check if this MR can be merged?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 30, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 30, 2025
@AungKoKoLin1997
Copy link
Copy Markdown
Author

AungKoKoLin1997 commented Dec 1, 2025

@oca/crm-maintainers
Can we get this PR merged?

kanda999
kanda999 approved these changes Dec 6, 2025
View reviewed changes
Copy link
Copy Markdown

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functioanl review: It works as expected.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia left review comments

@yostashiro yostashiro yostashiro approved these changes

@damdam-s damdam-s damdam-s approved these changes

@kanda999 kanda999 kanda999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AungKoKoLin1997 @OCA-git-bot @moitabenfdz @yostashiro @damdam-s @kanda999 @BhaveshHeliconia