[18.0][IMP] l10n_br_fiscal: add NBS criteria to tax definition#4654
Draft
marcelsavegnago wants to merge 2 commits into
Draft
[18.0][IMP] l10n_br_fiscal: add NBS criteria to tax definition#4654marcelsavegnago wants to merge 2 commits into
marcelsavegnago wants to merge 2 commits into
Conversation
Contributor
|
Hi @renatonlima, @rvalyi, |
97278a7 to
409a5ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for managing and searching NBS (Nomenclatura Brasileira de Serviços) codes in the fiscal tax definition module, similar to the existing NBM and CEST support. The changes include new fields, search logic, and UI updates to allow users to associate, search, and filter tax definitions by NBS codes.
NBS (Nomenclatura Brasileira de Serviços) support:
l10n_br_fiscal.tax.definitionandl10n_br_fiscal.nbsmodels to store and relate NBS codes (nbss,not_in_nbss,nbs_ids, andtax_definition_ids). [1] [2]action_search_nbssmethod to allow searching and assigning NBS codes based on user input, similar to the existing NBM logic. This method is now triggered on create and write when thenbssfield is updated. [1] [2] [3]Domain and mapping logic enhancements:
_get_search_domainandmap_tax_definitionmethods to include NBS code logic, ensuring tax definitions can be filtered and mapped using NBS codes in addition to NBM and CEST. [1] [2] [3] [4] [5]User interface improvements: