Skip to content

[18.0][IMP] l10n_br_fiscal: add NBS criteria to tax definition#4654

Draft
marcelsavegnago wants to merge 2 commits into
OCA:18.0from
Escodoo:18.0-l10n_br_fiscal-add-nbs-criteria-to-tax_definition
Draft

[18.0][IMP] l10n_br_fiscal: add NBS criteria to tax definition#4654
marcelsavegnago wants to merge 2 commits into
OCA:18.0from
Escodoo:18.0-l10n_br_fiscal-add-nbs-criteria-to-tax_definition

Conversation

@marcelsavegnago

Copy link
Copy Markdown
Member

This pull request introduces support for managing and searching NBS (Nomenclatura Brasileira de Serviços) codes in the fiscal tax definition module, similar to the existing NBM and CEST support. The changes include new fields, search logic, and UI updates to allow users to associate, search, and filter tax definitions by NBS codes.

NBS (Nomenclatura Brasileira de Serviços) support:

  • Added new fields to l10n_br_fiscal.tax.definition and l10n_br_fiscal.nbs models to store and relate NBS codes (nbss, not_in_nbss, nbs_ids, and tax_definition_ids). [1] [2]
  • Implemented the action_search_nbss method to allow searching and assigning NBS codes based on user input, similar to the existing NBM logic. This method is now triggered on create and write when the nbss field is updated. [1] [2] [3]

Domain and mapping logic enhancements:

  • Updated the _get_search_domain and map_tax_definition methods to include NBS code logic, ensuring tax definitions can be filtered and mapped using NBS codes in addition to NBM and CEST. [1] [2] [3] [4] [5]

User interface improvements:

  • Added a new "NBS" tab to the tax definition form view, allowing users to input, search, and view associated NBS codes in the UI.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @renatonlima, @rvalyi,
some modules you are maintaining are being modified, check this out!

@marcelsavegnago marcelsavegnago force-pushed the 18.0-l10n_br_fiscal-add-nbs-criteria-to-tax_definition branch from 97278a7 to 409a5ed Compare July 8, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants