[19.0][MIG] product_total_weight_from_packaging - #2368
Draft
JasminSForgeFlow wants to merge 27 commits into
Draft
JasminSForgeFlow wants to merge 27 commits into
JasminSForgeFlow wants to merge 27 commits into
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_total_weight_from_packaging Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_total_weight_from_packaging/
…x_weight The max_weight is a concept that was introduced in odoo delivery module to define the transporter weight limit for the shipped packaging. Before v16, the transporter packaging and product packaging was the same model product.packaging. Now the transporter packaging is moved to the model stock.package.type. In v13, max_weight defined in delivery module on product.packaging was used also for product packaging dimension. In v14, the weight field was added on the product.packaging and the max_weight was still coming from delivery module. This was introducing inconsistency as some modules migrated from v13 to v14 still rely on max_weight and some rely on the new weight field. In v16, we have to drop this max_weight on product.packaging as the delivery module moved it to stock.package.type and we should rely only on the weight field. The migration of the product_packaging_dimension OCA#1161 has to be fixed to not expose the old max_weight field and any data on max_weight must be moved to weight if empty. This module also deserves a big warning that it is lacking the weight uom conversions as it depends on product_packaging_dimension that depends on product_logistics_uom that allows to set a uom on the weight. The sum in this module is assuming all weights are in kg Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>
Currently translated at 100.0% (1 of 1 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_total_weight_from_packaging Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_total_weight_from_packaging/sl/
OCA-git-bot
added
series:19.0
mod:product_total_weight_from_packaging
legalsylvain
marked this pull request as draft
August 6, 2026 13:17
AaronHForgeFlow
approved these changes
Aug 6, 2026
AaronHForgeFlow
left a comment
AaronHForgeFlow
left a comment
Contributor
There was a problem hiding this comment.
functional + code. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency change
product_packaging_dimension→product_packaging.Odoo 19 removed the
product.packagingmodel, and in 19.0 the OCA split puts thepackaging
weighton the newproduct_packagingmodule, whileproduct_packaging_dimensionkeeps dimensions only. This module only needs theweight, so it now depends on
product_packagingdirectly.Depends on:
Changes
get_total_weight_from_packaging()reworked for the 19.0 packaging model:product_packaging_calculatornow yields packagings identified by theiruom.uom, so packaging weights are looked up onproduct.packagingkeyed byuom_idinstead of browsingproduct.packagingby the calculator id.weight_uom_idanymore (
product.packaging.weight_uom_nameis related to the product's), sopackaging weights and the product weight are already expressed in the same UoM
and summing them directly is correct. The dependency on
product_logistics_uom(through
product_packaging_dimension) is therefore no longer needed, and theREADME warning about the missing conversions is obsolete.
quantity falls back to the smaller packagings and finally to the product weight.
@ForgeFlow