Skip to content

[18][product_catalog_stock][FIX] Remove Form usage outside tests - #2400

Open
florian-dacosta wants to merge 1 commit into
OCA:18.0from
akretion:18-fix-warning-form-outside-test
Open

florian-dacosta wants to merge 1 commit into
OCA:18.0from
akretion:18-fix-warning-form-outside-test

Conversation

@florian-dacosta

Copy link
Copy Markdown

Because of the use of Form, I have these error logs using this module. (we can't see in the OCA CI logs because it does not trigger when test-enable option is passed.
This PR aims to remove the use of Form which does not seem unavoidable in this case.

@CarlosRoca13 @victoralmau @pedrobaeza

2026-09-09 13:05:04,344 2173 ERROR db odoo.tests.common: Importing test framework, avoid importing from business modules and when not running in test mode 
Stack (most recent call last):
  File "/odoo/bin/odoo", line 8, in <module>
    odoo.cli.main()
  File "/odoo/src/odoo/cli/command.py", line 76, in main
    o.run(args)
  File "/odoo/src/odoo/cli/server.py", line 182, in run
    main(args)
  File "/odoo/src/odoo/cli/server.py", line 175, in main
    rc = odoo.service.server.start(preload=preload, stop=stop)
  File "/odoo/src/odoo/service/server.py", line 1512, in start
    rc = server.run(preload, stop)
  File "/odoo/src/odoo/service/server.py", line 646, in run
    rc = preload_registries(preload)
  File "/odoo/src/odoo/service/server.py", line 1416, in preload_registries
    registry = Registry.new(dbname, update_module=update_module)
  File "/odoo/lib/python3.12/site-packages/decorator.py", line 232, in fun
    return caller(func, *(extras + args), **kw)
  File "/odoo/src/odoo/tools/func.py", line 97, in locked
    return func(inst, *args, **kwargs)
  File "/odoo/src/odoo/modules/registry.py", line 118, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/odoo/src/odoo/modules/loading.py", line 485, in load_modules
    processed_modules += load_marked_modules(env, graph,
  File "/odoo/src/odoo/modules/loading.py", line 365, in load_marked_modules
    loaded, processed = load_module_graph(
  File "/odoo/src/odoo/modules/loading.py", line 186, in load_module_graph
    load_openerp_module(package.name)
  File "/odoo/src/odoo/modules/module.py", line 384, in load_openerp_module
    __import__(qualname)
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/odoo/links/product_catalog_stock/__init__.py", line 1, in <module>
    from . import models
  File "<frozen importlib._bootstrap>", line 1415, in _handle_fromlist
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/odoo/links/product_catalog_stock/models/__init__.py", line 2, in <module>
    from . import stock_picking_type
  File "<frozen importlib._bootstrap>", line 1415, in _handle_fromlist
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/odoo/links/product_catalog_stock/models/stock_picking_type.py", line 4, in <module>
    from odoo.tests import Form
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/odoo/src/odoo/tests/__init__.py", line 8, in <module>
    from . import common
  File "<frozen importlib._bootstrap>", line 1415, in _handle_fromlist
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/odoo/src/odoo/tests/common.py", line 100, in <module>
    _logger.error(

@OCA-git-bot OCA-git-bot added series:18.0 mod:product_catalog_stock Module product_catalog_stock labels Sep 9, 2026
@pedrobaeza pedrobaeza added this to the 18.0 milestone Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:product_catalog_stock Module product_catalog_stock series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants