[19.0][MIG] sequence_python #3478
Open
+1,373
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 31, 2025 15:18
- Add proper string conversion for non-string return values from Python code
in sequence evaluation to prevent TypeError during string concatenation
- Use isinstance check to only convert non-string values, preserving
original behavior for string results
- Add test case to verify handling of integer return values from Python code
- Use separate sequence in test to avoid interference with other tests
The fix ensures that when Python code in sequence evaluation returns
non-string values (like integers), they are properly converted to strings
before concatenation with prefix and suffix, preventing TypeError.
Fixes potential issue where Python expressions returning integers or
other non-string types would cause concatenation errors.
bosd
force-pushed
the
19-mig-sequence_python
branch
from
12ddf28 to
b9fca8c
Compare
Contributor
Author
|
/ocabot migration sequence_python |
Contributor
|
Sorry @bosd you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
added 2 commits
December 31, 2025 20:22
- Move UUID safe members computation to module level as a constant - Replace repeated computation in _get_python_eval_context with constant lookup - Use _UUID_SAFE_MEMBERS constant instead of computing uuid_elements on each call - Improves performance by avoiding redundant computation on every sequence evaluation This optimization pre-computes the UUID safe members list once at module import time instead of recomputing it on every call to _get_python_eval_context, which can happen frequently during sequence operations.
Contributor
|
/ocabot migrationsequemce_pythom |
Contributor
|
Hi @thomaspaulb. Your command failed:
Ocabot commands
More information
|
Contributor
|
/ocabot migration sequence_python |
thomaspaulb
approved these changes
Jan 25, 2026
Contributor
thomaspaulb
left a comment
thomaspaulb
left a comment
There was a problem hiding this comment.
Nice additions! Maybe add yourself as a contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on unmerged: #3258