Skip to content

Do minor changes to cmake files#473

Closed
apteryks wants to merge 1 commit intoOGRECave:masterfrom
apteryks:backport-ogre-cmake-module-path-fix
Closed

Do minor changes to cmake files#473
apteryks wants to merge 1 commit intoOGRECave:masterfrom
apteryks:backport-ogre-cmake-module-path-fix

Conversation

@apteryks
Copy link
Copy Markdown

@apteryks apteryks commented Nov 6, 2024

This is a partial port of the commit
3568f43cd5b1e246aec3f1347fc353f388885f1a from the ogre (not ogre-next) repository, omitting the zip header change which doesn't apply.

  • MacroLogFeature: Clarify that even if a package is found it will not be used if a feature is disabled
  • Use list append on CMAKE_MODULE_PATH to allow prepending it with toolchain file, which is used with conan recipe.

This is a partial port of the commit
3568f43cd5b1e246aec3f1347fc353f388885f1a from the ogre (not ogre-next)
repository, omitting the zip header changes which doesn't apply.

  * MacroLogFeature: Clarify that even if a package is found it will not be used if a feature is disabled
  * Use list append on CMAKE_MODULE_PATH to allow prepending it with toolchain file, which is used with conan recipe.
@apteryks
Copy link
Copy Markdown
Author

apteryks commented Nov 6, 2024

Closed in favor of #474 (they'd conflict if submitted individually).

@apteryks apteryks closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants