Making workflow editor more accessible#5273
Making workflow editor more accessible#5273harshit-soora wants to merge 2 commits intoOSC:masterfrom
Conversation
Bubballoo3
left a comment
There was a problem hiding this comment.
This is a great start. There are still some details to work out with focus navigation and connect/delete buttons, but that is easily the hardest part of the whole thing so no problem if it takes a little back and forth to nail down.
For example it llooks like the launchers end up in the order that they render, which is effectively random. They should be rendering in the same order that they appear in the project.
The only thing that I don't see addressed at all here is the edge selection. Like you did with launchers, edges should be focusable, communicate their position in the graph (eg. 'Edge from launcher A to launcher B' and respond to 'Enter' the same as a click.
If you want to handle graph communication (eg. labeling the entire canvas with text like 'Workflow graph containing 3 launchers. Launcher A with no dependecies. launcher B with no dependencies. Launcher C depends on launcher A and launcher B') in a different PR I think that is totally reasonable given the complexity with generating and updating the text.
Finally I think we should only try to tackle the UI in this PR, you can revert the form and I'll handle that separately.
|
|
||
| .edge:focus { | ||
| outline: none; | ||
| stroke: var(--accent); |
There was a problem hiding this comment.
stroke color is already being set by the main css rule. Overriding it during focus just means there is no way to tell if an edge is focused and selected. So the stroke rule here should just be removed.
| outline: none; | ||
| stroke: var(--accent); | ||
| stroke-width: 4; | ||
| filter: drop-shadow(0 0 3px var(--accent)); |
There was a problem hiding this comment.
I have tried playing around with the values here (including just removing it) and can't see any difference. It seems to be related to shadow or something, but might not be working the way you intend. If it is doing something on your end, could you attach screenshots of the effect?
There was a problem hiding this comment.
Sure, let me play around the css and add screenshots.
Bubballoo3
left a comment
There was a problem hiding this comment.
This is coming along super nicely and is currently very usable with just a keyboard. There are a few final points with css, but this is easily 95% of the way there.
Related to issue #5262
Fixed following