Skip to content

Add bypass block to job composer#5282

Merged
Bubballoo3 merged 1 commit intomasterfrom
add-bypass-to-job-composer-4959
Apr 6, 2026
Merged

Add bypass block to job composer#5282
Bubballoo3 merged 1 commit intomasterfrom
add-bypass-to-job-composer-4959

Conversation

@Bubballoo3
Copy link
Copy Markdown
Contributor

Fixes #4959. Copies the same approach from the dashboard into the job composer, including giving the main section the main-container id, and copying css styles to keep the skip button hidden unless it has focus.

@johrstrom
Copy link
Copy Markdown
Contributor

I'm noticing this in 4.1 dashboard as well, but do we need a tabindex='-1' for it to be the very first thing that's focusable? Seems like I keep landing on the 'ondemand' link when the page loads and i have to shift+tab (go back one link) to get to this.

@Bubballoo3
Copy link
Copy Markdown
Contributor Author

I think there might be some browser caching affecting where your focus goes, but for me I can

  • load the page
  • click into the page (move focus out of the browser taskbar)
  • press tab once

And the skip navigation button appears.

Another thing that I recall noticing with NVDA is that tab will start focus on whatever is currently being read. So if you do not respond quickly enough and NVDA begins to read the navbar items, the tab key will start you after the skip navigation button. I'd be curious to know what happens if you execute the steps above with and without NVDA enabled.

Besides the fact, tabindex='-1' removes an item from the focus order, but default focus order is supposed to match the DOM order, so there is no reason it shouldn't be first. Another thing we can compare this with is Github's skip navigation button, which I recall the same behavior happening on.

@johrstrom johrstrom self-requested a review April 6, 2026 20:14
Copy link
Copy Markdown
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@Bubballoo3 Bubballoo3 merged commit 62a502e into master Apr 6, 2026
26 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Review to Merged/Closed in PR Review Pipeline Apr 6, 2026
@Bubballoo3 Bubballoo3 deleted the add-bypass-to-job-composer-4959 branch April 6, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged/Closed

Development

Successfully merging this pull request may close these issues.

Bypass block for job composer

3 participants