Skip to content

Active jobs refactor 3#5284

Open
johrstrom wants to merge 6 commits intomasterfrom
active-jobs-refactor-3
Open

Active jobs refactor 3#5284
johrstrom wants to merge 6 commits intomasterfrom
active-jobs-refactor-3

Conversation

@johrstrom
Copy link
Copy Markdown
Contributor

Continues the activejobs refactor for accessability.

This limits the width of the extended data panels based on screen size. It also adds the extended_layout partial. Instead of sending it in the json body, it's just in the other partial, mostly for ease but also to keep the same size within that container div.

Also adds an active_jobs.scss because there was none and these classes should likely be activejobs specific.

Copy link
Copy Markdown
Contributor

@Bubballoo3 Bubballoo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely on the right track, and looks pretty good. I think some of the breakpoint rules can be adjusted a bit, as we don't need quite so many. These should also match the bootstrap breakpoints as closely as possible, so that we avoid any future issues with utility classes later on. Since the proper col-md-12 classes will handle medium breakpoints and below, we really only need

  • lg (992+, the first side-by-side layout)
  • xl (1200+)
  • xxl (1400+)

But other than the minutiae of the css rules, this works well and seems to be the correct approach.

@github-project-automation github-project-automation bot moved this from Awaiting Review to Changes Requested in PR Review Pipeline Apr 6, 2026
@Bubballoo3
Copy link
Copy Markdown
Contributor

It also looks like you may need to set the z-index on the extended details so that they render below menu dropdowns (though if you'd rather save that for the next one that works too).

image

@Bubballoo3
Copy link
Copy Markdown
Contributor

While the table overflow seems to be resolved, the issue of the extended panel not filling the full space in the vertical arrangement has returned. Should be replicable on any screen width < 992px

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Changes Requested

Development

Successfully merging this pull request may close these issues.

3 participants