Skip to content

r.out.ascii: Create an option to write a LISFLOOD compatible header#4695

Merged
petrasovaa merged 20 commits intoOSGeo:mainfrom
YannChemin:main
Oct 5, 2025
Merged

r.out.ascii: Create an option to write a LISFLOOD compatible header#4695
petrasovaa merged 20 commits intoOSGeo:mainfrom
YannChemin:main

Conversation

@YannChemin
Copy link
Copy Markdown
Contributor

The option applied by the "-l" flag permits to write an ASCII grid file compatible with the European LISFLOOD model (https://ec-jrc.github.io/lisflood-model/1_1_introduction_LISFLOOD/)

@github-actions github-actions Bot added raster Related to raster data processing C Related code is in C HTML Related code is in HTML module docs labels Nov 12, 2024
Comment thread raster/r.out.ascii/formspecific.c Outdated
Comment thread raster/r.out.ascii/main.c Outdated
Comment thread raster/r.out.ascii/main.c Outdated
Comment thread raster/r.out.ascii/main.c Outdated
@nilason nilason changed the title Create an option to write a LISFLOOD compatible header r.out.ascii: Create an option to write a LISFLOOD compatible header Nov 22, 2024
Comment thread raster/r.out.ascii/r.out.ascii.html
echoix and others added 2 commits March 19, 2025 18:23
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@echoix
Copy link
Copy Markdown
Member

echoix commented Mar 19, 2025

For your next PRs, you'll have more luck by not using the main branch of your fork for a PR

G_option_exclusive(flag.surfer, flag.noheader, NULL);
G_option_exclusive(flag.surfer, flag.modflow, NULL);
G_option_exclusive(flag.surfer, flag.lisflood, NULL);
G_option_exclusive(flag.lisflood, flag.modflow, NULL);
updated with Lisflood info
@YannChemin YannChemin requested review from echoix and petrasovaa July 4, 2025 08:44
@github-actions github-actions Bot added the markdown Related to markdown, markdown files label Jul 4, 2025
@YannChemin
Copy link
Copy Markdown
Contributor Author

YannChemin commented Jul 4, 2025

For your next PRs, you'll have more luck by not using the main branch of your fork for a PR

Do you mean something like that?

git checkout -b something-branch
git add something
git commit -m "that something is changed"
git push -u origin something-branch
gh pr create --base main --head something-branch --fill

@echoix
Copy link
Copy Markdown
Member

echoix commented Jul 4, 2025

For your next PRs, you'll have more luck by not using the main branch of your fork for a PR

Do you mean something like that?

git checkout -b something-branch
git add something
git commit -m "that something is changed"
git push -u origin something-branch
gh pr create --base main --head something-branch --fill

Yep, seems right

echoix
echoix previously requested changes Jul 4, 2025
Copy link
Copy Markdown
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure changing the relative markdown links from ending with ".md" to ending with ".html" is expected.

Comment thread raster/r.out.ascii/r.out.ascii.md Outdated
Comment thread raster/r.out.ascii/r.out.ascii.md Outdated
Comment thread raster/r.out.ascii/r.out.ascii.md Outdated
Copy link
Copy Markdown
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other questions on markdown syntax

Comment thread raster/r.out.ascii/r.out.ascii.md Outdated
Comment thread raster/r.out.ascii/r.out.ascii.md Outdated
Comment thread raster/r.out.ascii/r.out.ascii.md Outdated
petrasovaa
petrasovaa previously approved these changes Jul 18, 2025
Comment thread raster/r.out.ascii/r.out.ascii.html Outdated
@YannChemin YannChemin requested a review from echoix July 25, 2025 06:17
@nilason
Copy link
Copy Markdown
Contributor

nilason commented Oct 4, 2025

@echoix Any objections to merge?

@echoix
Copy link
Copy Markdown
Member

echoix commented Oct 4, 2025

@echoix Any objections to merge?

Apart from the fact that the PR comes from his main branch, probably not

@nilason
Copy link
Copy Markdown
Contributor

nilason commented Oct 4, 2025

@echoix Any objections to merge?

Apart from the fact that the PR comes from his main branch, probably not

Although not good practice, it wouldn’t mess things up, would it?

@echoix
Copy link
Copy Markdown
Member

echoix commented Oct 4, 2025

@echoix Any objections to merge?

Apart from the fact that the PR comes from his main branch, probably not

Although not good practice, it wouldn’t mess things up, would it?

Not that much what we can't survive. He'll need to use the GitHub UI to "discard x commits" on his fork to update his main after, then clean up locally too, or reclone if he doesn't want to bother finding how to discard his commits on main

@echoix echoix dismissed their stale review October 4, 2025 15:01

Will keep this branch

@petrasovaa petrasovaa merged commit 14fd3ee into OSGeo:main Oct 5, 2025
30 of 32 checks passed
@github-actions github-actions Bot added this to the 8.5.0 milestone Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C docs HTML Related code is in HTML markdown Related to markdown, markdown files module raster Related to raster data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants